zheng-da commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r183132338
########## File path: python/mxnet/contrib/quantization.py ########## @@ -72,7 +72,7 @@ def _quantize_params(qsym, params): return quantized_params -def _quantize_symbol(sym, excluded_symbols=None, offline_params=None): +def _quantize_symbol(sym, excluded_symbols=None, offline_params=None, context=cpu()): Review comment: I think quantization for CPU and GPU can be different. That's why the C API is changed above ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services