haojin2 commented on a change in pull request #10662: [MXNET-347] Logical AND
operator
URL: https://github.com/apache/incubator-mxnet/pull/10662#discussion_r183566292
##########
File path: tests/python/unittest/test_operator.py
##########
@@ -1564,6 +1564,13 @@ def test_bmin(a, b):
# pass idx=200 to gen_broadcast_data so that generated ndarrays' sizes
are not too big
data = gen_broadcast_data(idx=200)
check_bmaxmin_gradient(c, data[0], data[1], 0.001, 1e-2, 1e-3)
+
+ def test_band(a, b):
+ c = mx.sym.broadcast_logical_and(a, b)
+ check_binary_op_forward(c, lambda x, y: np.logical_and(x, y),
gen_broadcast_data, mx_nd_func=mx.nd.logical_and)
+ # pass idx=200 to gen_broadcast_data so that generated ndarrays' sizes
are not too big
+ data = gen_broadcast_data(idx=200)
+ check_bmaxmin_gradient(c, data[0], data[1], 0.001, 1e-2, 1e-3)
Review comment:
Is this a proper gradient check for this op?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
