yzhliu commented on a change in pull request #10660: [MXNET-357][WIP] New Scala
API Design
URL: https://github.com/apache/incubator-mxnet/pull/10660#discussion_r183909723
##########
File path:
scala-package/macros/src/main/scala/org/apache/mxnet/SymbolMacro.scala
##########
@@ -174,6 +183,10 @@ private[mxnet] object SymbolImplMacros {
println("Symbol function definition:\n" + docStr)
}
// scalastyle:on println
- (aliasName, new SymbolFunction(handle, keyVarNumArgs.value))
+ val argList = argNames zip argTypes map { case (argName, argType) =>
+ val tup = argumentCleaner(argType)
Review comment:
name the return tuple.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
