anirudhacharya commented on a change in pull request #10679: [MXNET-347] Logical Operators AND, XOR, OR URL: https://github.com/apache/incubator-mxnet/pull/10679#discussion_r184205812
########## File path: src/operator/mshadow_op.h ########## @@ -317,6 +317,12 @@ MXNET_BINARY_MATH_OP_NC(eq, a == b ? DType(1) : DType(0)); MXNET_BINARY_MATH_OP_NC(ne, a != b ? DType(1) : DType(0)); +MXNET_BINARY_MATH_OP(logical_and, a && b ? DType(1) : DType(0)); + +MXNET_BINARY_MATH_OP(logical_or, a || b ? DType(1) : DType(0)); + +MXNET_BINARY_MATH_OP(logical_xor, (a || b) && !(a && b) ? DType(1) : DType(0)); Review comment: meaning? use cases for having an implementation of these operators? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
