piiswrong commented on a change in pull request #10767: add reverse option to
ndarray inplace reshape
URL: https://github.com/apache/incubator-mxnet/pull/10767#discussion_r185695101
##########
File path: python/mxnet/ndarray/ndarray.py
##########
@@ -1032,15 +1045,14 @@ def reshape(self, *shape, **kwargs):
if len(kwargs) != 1:
raise TypeError("Only 'shape' is supported as keyword
argument. Got: {}."
.format(', '.join(kwargs.keys())))
- else:
- assert not kwargs,\
- "Specifying both positional and keyword arguments is not
allowed in reshape."
+ reverse = kwargs.get('reverse', False)
Review comment:
needs to make sure kwargs doesn't contain other arguments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
