haojin2 commented on a change in pull request #10645: [MXNET-354] Support
elemwise_add/sub between dense and row sparse tensors on CPU/GPU
URL: https://github.com/apache/incubator-mxnet/pull/10645#discussion_r185702871
##########
File path: tests/python/unittest/test_sparse_operator.py
##########
@@ -349,6 +349,18 @@ def check_elemwise_binary_ops(lhs_stype, rhs_stype, shape,
lhs_density=lhs_density,
rhs_density=rhs_density,
verbose=False)
+ if lhs_stype is 'default' and rhs_stype is 'row_sparse':
Review comment:
for elemwise_sub, inplace and writeto have the same code(remember the
negation step?)
Will add for dns, csr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
