marcoabreu commented on a change in pull request #10797: Better cleaning of git 
repo, signal handlers
URL: https://github.com/apache/incubator-mxnet/pull/10797#discussion_r186086546
 
 

 ##########
 File path: ci/docker/runtime_functions.sh
 ##########
 @@ -353,7 +369,18 @@ sanity_check() {
 }
 
 
+
+before_unittest() {
 
 Review comment:
   I open the overall log and search for the [ut-cpp-gpu], for example. The 
first occurence contains the machine name.
   
   I would rather have this as part of the build.py than in the runtime 
functions. They're supposed to only have logic and not boilerplate

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to