yzhliu commented on a change in pull request #10660: [MXNET-357] New Scala API
Design (Symbol)
URL: https://github.com/apache/incubator-mxnet/pull/10660#discussion_r187476303
##########
File path: scala-package/init/src/main/scala/org/apache/mxnet/init/Base.scala
##########
@@ -37,7 +37,11 @@ object Base {
@throws(classOf[UnsatisfiedLinkError])
private def tryLoadInitLibrary(): Unit = {
- val baseDir = System.getProperty("user.dir") + "/init-native"
+ // val baseDir = System.getProperty("user.dir") + "/init-native"
+ var baseDir = System.getProperty("user.dir") + "/init-native"
+ if (System.getenv().containsKey("BASEDIR")) {
+ baseDir = sys.env("BASEDIR")
+ }
Review comment:
for system environment var, better to specify it is mxnet-related, e.g.,
MXNET_SCALA_MACRO_BASEDIR or something like it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
