larroy commented on a change in pull request #10917: [MXNET-416] Add docker
cache
URL: https://github.com/apache/incubator-mxnet/pull/10917#discussion_r187994860
##########
File path: Jenkinsfile
##########
@@ -92,24 +92,34 @@ echo ${libs} | sed -e 's/,/ /g' | xargs md5sum
"""
}
+def docker_run(platform, function_name, use_nvidia, shared_mem = '500m') {
+ def command = "ci/build.py --download-docker-cache --docker-cache-bucket
${env.DOCKER_CACHE_BUCKET} %USE_NVIDIA% --platform %PLATFORM% --shm-size
%SHARED_MEM% /work/runtime_functions.sh %FUNCTION_NAME%"
+ command = command.replaceAll('%USE_NVIDIA%', use_nvidia ? '--nvidiadocker' :
'')
+ command = command.replaceAll('%PLATFORM%', platform)
+ command = command.replaceAll('%FUNCTION_NAME%', function_name)
+ command = command.replaceAll('%SHARED_MEM%', shared_mem)
+
+ sh command
+}
+
// Python unittest for CPU
// Python 2
def python2_ut(docker_container_name) {
timeout(time: max_time, unit: 'MINUTES') {
- sh "ci/build.py --platform ${docker_container_name}
/work/runtime_functions.sh unittest_ubuntu_python2_cpu"
+ docker_run(docker_container_name, 'unittest_ubuntu_python2_cpu', false)
Review comment:
I agree with Kellen, not blocking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
