yzhliu commented on a change in pull request #10787: [MXNET-357] New Scala API
Design (NDArray)
URL: https://github.com/apache/incubator-mxnet/pull/10787#discussion_r189128659
##########
File path:
scala-package/macros/src/main/scala/org/apache/mxnet/NDArrayMacro.scala
##########
@@ -102,20 +178,80 @@ private[mxnet] object NDArrayMacro {
result
}
+
+ // Convert C++ Types to Scala Types
+ private def typeConversion(in : String, argType : String = "") : String = {
Review comment:
can we have these functions shared with those in SymbolMacro?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
