eric-haibin-lin commented on a change in pull request #10451: [MXNET-432] Add
Foreach
URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r189722567
##########
File path: src/imperative/imperative_utils.h
##########
@@ -456,17 +458,24 @@ inline void PushOperator(const OpStatePtr& state,
if (fcompute_ex != nullptr && dispatch_mode == DispatchMode::kFComputeEx) {
const auto& run = [=](RunContext rctx,
engine::CallbackOnComplete on_complete) {
- OpContext opctx{is_train, rctx, on_complete, requested};
+ bool need_grad = Imperative::Get()->is_recording();
+ OpContext opctx{need_grad, is_train, rctx, on_complete, requested};
#if MXNET_USE_MKLDNN == 1
InvalidateOutputs(outputs, req);
#endif
fcompute_ex(state, opctx, inputs, req, outputs);
- if (ctx.dev_mask() == gpu::kDevMask && exec_type == ExecType::kSync) {
Review comment:
Good catch. I think we need to check
`bool is_gpu = rctx.get_ctx().dev_mask() == gpu::kDevMask;`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
