yzhliu commented on a change in pull request #11045: [MXNET-471] Add Builder
class for Scala Module and DataBatch to simplify construction
URL: https://github.com/apache/incubator-mxnet/pull/11045#discussion_r190490305
##########
File path: scala-package/core/src/main/scala/org/apache/mxnet/Symbol.scala
##########
@@ -101,7 +101,6 @@ class Symbol private(private[mxnet] val handle:
SymbolHandle) extends WarnIfNotD
var index: Int = -1
for ((output, i) <- listOutputs().view.zipWithIndex) {
if (output == name) {
- require(index == -1, s"There are multiple outputs with name $name")
Review comment:
I explained in the description of the PR:
> Regarding the change in Symbol.scala, it is a bug fix. Because we should
allow users to expose two outputs but with same name. for example,
https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/gluon/rnn/rnn_cell.py#L398
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
