nswamy commented on a change in pull request #11045: [MXNET-471] Add Builder
class for Scala Module and DataBatch to simplify construction
URL: https://github.com/apache/incubator-mxnet/pull/11045#discussion_r190669787
##########
File path:
scala-package/macros/src/main/scala/org/apache/mxnet/NDArrayMacro.scala
##########
@@ -69,7 +69,7 @@ private[mxnet] object NDArrayMacro {
// e.g def transpose(kwargs: Map[String, Any] = null)(args: Any*)
q"def $termName(kwargs: Map[String, Any] = null)(args: Any*) =
{genericNDArrayFunctionInvoke($funcName, args, kwargs)}".asInstanceOf[DefDef],
// e.g def transpose(args: Any*)
- q"def $termName(args: Any*) =
{genericNDArrayFunctionInvoke($funcName, args, null)}".asInstanceOf[DefDef]
+ q"@scala.annotation.varargs def $termName(args: Any*) =
{genericNDArrayFunctionInvoke($funcName, args, null)}".asInstanceOf[DefDef]
Review comment:
Why do we need to all APIs to have @vaargs. This will mean we will have to
maintain this functionality going forward and I don't think this is an optimal
solution. -- We are trying to get rid of this sooner and move to the new APIs
right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
