piiswrong commented on a change in pull request #10864: Support for axis
parameter in linalg.gemm
URL: https://github.com/apache/incubator-mxnet/pull/10864#discussion_r190677479
##########
File path: src/operator/tensor/la_op.h
##########
@@ -53,13 +54,17 @@ struct LaMatrixMacParam : public
dmlc::Parameter<LaMatrixMacParam> {
DMLC_DECLARE_FIELD(beta)
.set_default(1.0)
.describe("Scalar factor multiplied with C.");
+ DMLC_DECLARE_FIELD(axis)
+ .set_default(-2)
+ .describe("Axis corresponding to the matrix rows.");
Review comment:
I see. I'm not familiar with the context, but I want to make sure we are not
creating new conventions unless we have to.
Does this solve a different use case from theano's tensordot formulation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
