marcoabreu commented on a change in pull request #11053: Fixed armv7 wheel
URL: https://github.com/apache/incubator-mxnet/pull/11053#discussion_r190733461
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -83,31 +102,40 @@ build_armv6() {
-DBUILD_CPP_EXAMPLES=OFF \
-Dmxnet_LINKER_LIBS=-lgfortran \
-G Ninja /work/mxnet
+
ninja
- export MXNET_LIBRARY_PATH=`pwd`/libmxnet.so
- cd /work/mxnet/python
- python setup.py bdist_wheel --universal
- cp dist/*.whl /work/build
+ build_wheel
+
popd
}
build_armv7() {
set -ex
pushd .
cd /work/build
- cmake\
- -DUSE_CUDA=OFF\
- -DUSE_OPENCV=OFF\
- -DUSE_OPENMP=OFF\
- -DUSE_SIGNAL_HANDLER=ON\
- -DCMAKE_BUILD_TYPE=RelWithDebInfo\
- -DUSE_MKL_IF_AVAILABLE=OFF\
+
+ # Lapack functionality will be included and statically linked to openblas.
Review comment:
This sounds a bit like a hack to me. Could we have proper handling for that?
Otherwise, there might be other things that depend on the USE_LAPACK flag that
are not getting triggered because it's expected to be absent while it's
actually there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
