yzhliu commented on a change in pull request #11045: [MXNET-471] Add Builder
class for Scala Module and DataBatch to simplify construction
URL: https://github.com/apache/incubator-mxnet/pull/11045#discussion_r191063902
##########
File path: scala-package/core/src/main/scala/org/apache/mxnet/Shape.scala
##########
@@ -28,6 +30,7 @@ class Shape(dims: Traversable[Int]) extends Serializable {
}
def apply(dim: Int): Int = shape(dim)
+ def get(dim: Int): Int = apply(dim)
Review comment:
Don't see any advantage to make Shape as a collection, what I meant is,
get(idx) is a code convention for get element of an index. Even though we make
Shape extend Collection, but which? Collection in Java, or in Scala? which
Collection? we should design. We can leave it later, otherwise this will be
experimental.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
