jinhuang415 commented on issue #11090: Define build target for mkldnn lib build to fix 'make clean USE_MKMLDNN=1' issue URL: https://github.com/apache/incubator-mxnet/pull/11090#issuecomment-392808644 @szha @zheng-da I opened a new PR to fix 'make clean USE_MKLDNN=1" issue since previous PR is messed up (https://github.com/apache/incubator-mxnet/pull/10783), please help to take a look at the new solution. @TaoLv @ashokei @pengzhao-intel I made some change/cleanup about current mkldnn library build logic so there will be less corner cases, would you also help to review the change? The main logic difference with previous prepare_mkldnn.sh is below (please help to double confirm whether it's ok): (1) there is complicated logic in prepare_mkldnn.sh to determine the MKLROOT, in order to make logic simple and not error prone, I changed to always download mklml (so mkldnn will always use mklml) so MKLROOT is the same with MKLDNNROOT and the set logic is simple now (2) I removed the ldconfig part since looks it only applies to Linux and need to set when user specify MKLDNN_ROOT, since we can use LD_LIBRARY_PATH and also want to keep mkldnn.mk simple, so I removed this logic (if it's regarded as necessary I can add this back)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
