pengzhao-intel commented on a change in pull request #11047: Enhance mkldnn
pooling to support full convention
URL: https://github.com/apache/incubator-mxnet/pull/11047#discussion_r191629708
##########
File path: src/operator/nn/mkldnn/mkldnn_pooling.cc
##########
@@ -150,6 +150,16 @@ mkldnn::pooling_forward::primitive_desc
GetPoolingFwd(const PoolingParam ¶m,
int pad_l_ = param.pad[1], pad_r_ = param.pad[1];
int stride_h_ = param.stride[0], stride_w_ = param.stride[1];
+ if (param.pooling_convention == pool_enum::kFull) {
Review comment:
Is it possible to write up a macro/function for the same check of `kFull` in
the different place in this file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
