eric-haibin-lin commented on a change in pull request #11113: Support for
dot(dns, csr) = dns and dot(dns, csr.T) = dns on CPU
URL: https://github.com/apache/incubator-mxnet/pull/11113#discussion_r192551420
##########
File path: src/operator/tensor/dot-inl.h
##########
@@ -264,11 +264,15 @@ inline bool DotForwardInferStorageType(const
nnvm::NodeAttrs& attrs,
if (!dispatched && lhs_stype == kDefaultStorage && rhs_stype == kCSRStorage
&&
!param.transpose_a) {
target_stype = hint_has_value ? target_stype : kCSRStorage;
- // dns, csr -> csr on CPU
Review comment:
Please also update doc in
https://github.com/apache/incubator-mxnet/blob/master/src/operator/tensor/dot.cc#L63-L64
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
