haojin2 commented on a change in pull request #11024: [MXNET-394] concat of CSR
NDArrays on first dimension
URL: https://github.com/apache/incubator-mxnet/pull/11024#discussion_r192552699
##########
File path: src/operator/nn/concat-inl.h
##########
@@ -154,6 +154,82 @@ void ConcatGradCompute(const nnvm::NodeAttrs& attrs,
const OpContext& ctx,
});
}
+
+struct concat_csr_first_dim {
+ // i is the i-th row of the output ndarray
Review comment:
Better add more comments for all arguments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
