lanking520 commented on a change in pull request #11126: [MXNET-386] ongoing maintenance on NDArray URL: https://github.com/apache/incubator-mxnet/pull/11126#discussion_r192968711
########## File path: scala-package/macros/src/main/scala/org/apache/mxnet/NDArrayMacro.scala ########## @@ -129,6 +119,8 @@ private[mxnet] object NDArrayMacro { } impl += base }) + // add default out parameter + argDef += "out : Option[NDArray] = None" Review comment: The usage is to save memory space, you pass in a pointer and C will store the value in there... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services