larroy commented on a change in pull request #11053: [MXNET-244] Fixed armv7
wheel
URL: https://github.com/apache/incubator-mxnet/pull/11053#discussion_r193372651
##########
File path: CMakeLists.txt
##########
@@ -339,7 +339,11 @@ if(USE_OPENMP)
find_package(OpenMP REQUIRED)
# This should build on Windows, but there's some problem and I don't have a
Windows box, so
# could a Windows user please fix?
- if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/openmp/CMakeLists.txt AND
SYSTEM_ARCHITECTURE STREQUAL "x86_64" AND NOT MSVC)
+ if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/openmp/CMakeLists.txt
+ AND SYSTEM_ARCHITECTURE STREQUAL "x86_64"
+ AND NOT MSVC
+ AND NOT CMAKE_CROSSCOMPILING)
Review comment:
How is CMAKE_CROSSCOMPILING enabled/governed? For android I noticed we are
not in "cross compiling" mode or whatever that is supposed to be in cmake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
