marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r193374740
########## File path: tests/python/quantization/test_quantization.py ########## @@ -319,6 +339,11 @@ def check_quantized_flatten(shape): @with_seed() def test_quantize_params(): + if is_test_for_mkldnn(): + dtype = 'uint8' Review comment: Why different dtypes? the test is written to target int8, so why test uint8 now? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
