eric-haibin-lin commented on a change in pull request #11024: [MXNET-394]
concat of CSR NDArrays on first dimension
URL: https://github.com/apache/incubator-mxnet/pull/11024#discussion_r194191311
##########
File path: src/operator/nn/concat.cc
##########
@@ -156,17 +167,23 @@ static void ConcatComputeExCPU(const nnvm::NodeAttrs&
attrs,
CHECK_EQ(outputs.size(), 1U);
CHECK_EQ(req.size(), 1U);
if (req[0] == kNullOp) return;
- // MKLDNN support 2D and 4D concat
- if ((inputs[0].shape().ndim() == 2 || inputs[0].shape().ndim() == 4)
+ if (common::ContainsOnlyStorage(inputs, kCSRStorage)) {
Review comment:
common::ContainsOnlyStorage(inputs, kCSRStorage) && output.stype == kCSR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
