szha commented on a change in pull request #11041: gpu mem pool strategy URL: https://github.com/apache/incubator-mxnet/pull/11041#discussion_r194471060
########## File path: tests/python/unittest/test_sparse_operator.py ########## @@ -16,7 +16,7 @@ # under the License. from mxnet.test_utils import * -from common import setup_module, with_seed +from common import setup_module, with_seed, teardown Review comment: applying this change would allow all tests within a module to finish before moving onto the next test, thus eliminating the case where side effect of tests in another module spills over to the next. In terms of testing practice, including a setup/teardown is common. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
