zhreshold commented on a change in pull request #11213: [MXNET-533] MXNet-ONNX 
export
URL: https://github.com/apache/incubator-mxnet/pull/11213#discussion_r194632621
 
 

 ##########
 File path: python/mxnet/contrib/onnx/__init__.py
 ##########
 @@ -18,3 +18,4 @@
 
 from ._import.import_model import import_model, get_model_metadata
 
 Review comment:
   this does not make sense to me.
   why do you want to put public function in private module folder `_import` or 
`_export` and include them later?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to