lebeg commented on a change in pull request #10827: [MXNET-405][WIP] Add 2 new 
pipelines to the Official CI and run nightly tests. 
URL: https://github.com/apache/incubator-mxnet/pull/10827#discussion_r194648900
 
 

 ##########
 File path: tests/jenkins/run_test_installation_docs.sh
 ##########
 @@ -262,29 +262,47 @@ LINUX_PYTHON_CPU_END_LINENO=$(grep -n "END - Linux 
Python CPU Installation Instr
 
 set_instruction_set ${LINUX_PYTHON_CPU_START_LINENO} 
${LINUX_PYTHON_CPU_END_LINENO}
 
-echo
-echo "### Testing Virtualenv ###"
-echo "${virtualenv_commands}"
-echo
-docker run --rm ubuntu:14.04 bash -c "${virtualenv_commands}"
+ubuntu_python_cpu_virtualenv()
+{
+    echo
+    echo "### Testing Virtualenv ###"
+    echo "${virtualenv_commands}" #> "$filewithcommands"
+    echo
+    eval ${virtualenv_commands}
+    echo "ubuntu_python_cpu_virtualenv: MXNet Installed Successfully"
+}
 
-echo
-echo "### Testing Pip ###"
-echo "${pip_commands}"
-echo
-docker run --rm ubuntu:14.04 bash -c "${pip_commands}"
+ubuntu_python_cpu_pip()
+{
+    echo
+    echo "### Testing Pip ###"
+    echo "${pip_commands}"
+    echo
+    eval ${pip_commands}
+    echo "ubuntu_python_cpu_pip: MXNet Installed Successfully"
 
 Review comment:
   It is easy to make a mistake manually typing in all the names and statuses. 
You could create a print_success function like this:
   
   ```
   print_success() {
       echo "${FUNCNAME[1]}: MXNet Installed Successfully"
   }
   ```
   which will print the calling functions name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to