nswamy commented on a change in pull request #11126: [MXNET-386] ongoing maintenance on NDArray URL: https://github.com/apache/incubator-mxnet/pull/11126#discussion_r194704368
########## File path: scala-package/macros/src/main/scala/org/apache/mxnet/APIDocGenerator.scala ########## @@ -97,9 +97,11 @@ private[mxnet] object APIDocGenerator{ argDef += "name : String = null" argDef += "attr : Map[String, String] = null" } else { + argDef += "out : Option[NDArray] = None" returnType = "org.apache.mxnet.NDArrayFuncReturn" } - s"def ${func.name} (${argDef.mkString(", ")}) : ${returnType}" + val experimentalTag = "@Experimental" Review comment: @marcoabreu @yzhliu look at the code, this Experimental annotation was created by Qing which does not have implementation, it is not a language supported feature for you to get WARNING on compile, you have to make it happen in your implementation using. I did not say you have to log it at Runtime. Annotations without any implementations are just markers, the IDE neither the compiler will not do anything. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services