nswamy commented on issue #11126: [MXNET-386] ongoing maintenance on NDArray URL: https://github.com/apache/incubator-mxnet/pull/11126#issuecomment-396652353 Does it work? > On Jun 12, 2018, at 6:23 PM, Lanking <[email protected]> wrote: > > @lanking520 commented on this pull request. > > In scala-package/core/src/main/scala/org/apache/mxnet/annotation/Experimental.scala: > > > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > + * See the License for the specific language governing permissions and > + * limitations under the License. > + */ > + > +package org.apache.mxnet.annotation > + > +import java.lang.annotation.{ElementType, Retention, Target, _} > + > +@Retention(RetentionPolicy.RUNTIME) > +@Target(Array(ElementType.TYPE, ElementType.FIELD, ElementType.METHOD, ElementType.PARAMETER, > + ElementType.CONSTRUCTOR, ElementType.LOCAL_VARIABLE, ElementType.PACKAGE)) > +class Experimental {} > @nswamy , Scala does not support interface, we need to use an Class to replace that. Shall we follow the "Scala way" to do the annotation rather than java? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
