anirudh2290 commented on a change in pull request #11210: [MXNET-532] Clarify documentation of save_params(), load_params(), export() URL: https://github.com/apache/incubator-mxnet/pull/11210#discussion_r194876492
########## File path: python/mxnet/gluon/block.py ########## @@ -309,6 +309,17 @@ def _collect_params_with_prefix(self, prefix=''): def save_params(self, filename): """Save parameters to file. + This function is to be used to save parameters of a Gluon model, note that + the saved parameters are not meant to be loaded in a different language binding for now. + Saving parameters using `.save_params()` is different than + `.collect_params().save()`, which is a deprecated way to save parameters of a model + and should be avoided. Review comment: @piiswrong agree that `save_params` and `load_params` are deprecated but we would want to educate users about this. we can remove L312 to L316. We can keep the L317 to L322 and add the line that this function is deprecated, please see save_parameters(), at the start of L317. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services