zheng-da commented on issue #11212: cherry-pick bug fixes in MKLDNN for v1.2.0 URL: https://github.com/apache/incubator-mxnet/pull/11212#issuecomment-396762289 this test was from the PR https://github.com/apache/incubator-mxnet/pull/10578/files. On Tue, Jun 12, 2018 at 4:01 PM, Anirudh Subramanian < notificati...@github.com> wrote: > *@anirudh2290* commented on this pull request. > ------------------------------ > > In tests/cpp/operator/mkldnn.cc > <https://github.com/apache/incubator-mxnet/pull/11212#discussion_r194913920> > : > > > @@ -81,13 +81,6 @@ TEST(MKLDNN_UTIL_FUNC, AlignMem) { > #endif > } > > -TEST(MKLDNN_UTIL_FUNC, MemFormat) { > - // Check whether the number of format is correct. > - CHECK_EQ(mkldnn_format_last, 56); > - CHECK_EQ(mkldnn_nchw, 5); > - CHECK_EQ(mkldnn_oihw, 12); > > why are these unnecessary tests and how are they running on master ? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-mxnet/pull/11212#pullrequestreview-128178880>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAETUTBnTKXGftIH8FN6a0cLbRhn6uL2ks5t8EhDgaJpZM4Ug_CB> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
