ThomasDelteil commented on a change in pull request #11210: [MXNET-532] Clarify 
documentation of save_params(), load_params(), export()
URL: https://github.com/apache/incubator-mxnet/pull/11210#discussion_r195183961
 
 

 ##########
 File path: python/mxnet/gluon/block.py
 ##########
 @@ -309,6 +309,17 @@ def _collect_params_with_prefix(self, prefix=''):
 
     def save_params(self, filename):
         """Save parameters to file.
+        This function is to be used to save parameters of a Gluon model, note 
that
+        the saved parameters are not meant to be loaded in a different 
language binding for now.
+        Saving parameters using `.save_params()` is different than
+        `.collect_params().save()`, which is a deprecated way to save 
parameters of a model
+        and should be avoided.
 
 Review comment:
   ok will wait for the other PR to be merged...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to