rahul003 commented on a change in pull request #10696: [MXNET-366]Extend MXNet 
Distributed Training by AllReduce
URL: https://github.com/apache/incubator-mxnet/pull/10696#discussion_r195257681
 
 

 ##########
 File path: src/kvstore/kvstore.cc
 ##########
 @@ -49,6 +53,19 @@ KVStore* KVStore::Create(const char *type_name) {
     use_device_comm = true;
   }
 
+#if MXNET_USE_ALLREDUCE_DIST_KVSTORE
+  if (has("dist_sync_allreduce")) {
+    kv = new kvstore::KVStoreDistSyncAllReduce();
+    kv->type_ = tname;
+    return kv;
+  }
+#else
+  if (has("dist_sync_allreduce")) {
+    LOG(FATAL) << "compile with USE_ALLREDUCE_DIST_KVSTORE=1 to use " << tname;
+    return nullptr;
+  }
+#endif
+
   if (has("dist")) {
 
 Review comment:
   make this else if?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to