piiswrong commented on a change in pull request #11027: Add standard ResNet 
data augmentation for ImageRecordIter
URL: https://github.com/apache/incubator-mxnet/pull/11027#discussion_r195583935
 
 

 ##########
 File path: src/io/image_aug_default.cc
 ##########
 @@ -218,10 +265,93 @@ class DefaultImageAugmenter : public ImageAugmenter {
       res = src;
     }
 
+    if (param_.random_resized_crop) {
+      // random resize crop
+      CHECK(param_.min_random_scale == 1.0f &&
+        param_.max_random_scale == 1.0f &&
+        param_.min_crop_size == -1 &&
+        param_.max_crop_size == -1 &&
+        !param_.rand_crop) <<
+        "\nSetting random_resized_crop to true conflicts with "
+        "min_random_scale, max_random_scale, "
+        "min_crop_size, max_crop_size, "
+        "and rand_crop.";
+      if (param_.max_random_area != 1.0f || param_.min_random_area != 1.0f
+          || param_.max_aspect_ratio != 1.0f || param_.min_aspect_ratio != 
1.0f) {
 
 Review comment:
   if these are all 1.0, you still need to resize the image right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to