zheng-da commented on a change in pull request #10451: [MXNET-432] Add Foreach URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r195915304
########## File path: src/operator/subgraph_op_common.h ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#ifndef MXNET_OPERATOR_SUBGRAPH_OP_COMMON_H_ +#define MXNET_OPERATOR_SUBGRAPH_OP_COMMON_H_ + +#include <mxnet/io.h> +#include <mxnet/base.h> +#include <mxnet/op_attr_types.h> +#include <vector> +#include "../imperative/cached_op.h" +#include "../imperative/imperative_utils.h" + +namespace mxnet { +namespace op { + +/* + * Infer the data types of inputs and outputs of an operator that contains a + * subgraph. + */ +bool InferSubgraphDataType(const nnvm::Symbol &subgraph, std::vector<int> *in_type, + std::vector<int> *out_type); + +/* + * Infer the storage types of inputs and outputs of an operator that contains a + * subgraph. + */ +bool InferSubgraphStorage(const nnvm::Symbol &subgraph, + const int dev_mask, + DispatchMode* dispatch_mode, + std::vector<int> *in_attrs, + std::vector<int> *out_attrs); + +/* + * Infer the storage types of inputs and outputs of the backward computation of + * an operator that contains a subgraph. + */ +bool InferSubgraphBackwardStorage(const nnvm::Symbol &subgraph, + const int dev_mask, + DispatchMode* dispatch_mode, + std::vector<int> *in_attrs, + std::vector<int> *out_attrs); + +/* + * This contains the states for running a loop and provides methods + * of running the subgraph computation for an iteration. + */ +class LoopState { Review comment: it's supposed to be shared by while loop. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
