asitstands commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-397852430 I added the cython build to Python3 CentOS 7 CPU and GPU environments. I have made an intentional bug in the cython module and confirmed that it actually causes [the failures of the unit tests](http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-10951/16/pipeline/739). I think that now this PR is completed. Please review the code. Here is the summary of the changes. 1. A bug in the `setup.py` which causes problems with the recent cython 0.28 (#10295, #10738) is fixed. 1. The cython module for the ndarray has caused segmentation faults since the introduction of the sparse array. This is fixed. 1. Now the compiled cython module has `rpath` to find `libmxnet.so`, so the deployment is easier. 1. A new makefile variable `PYTHON` to set the python executable is added (`make/config.mk`). The cython build target needs to run python but some environments have nonstandard executable name such as `python3.6`. 1. Documentation for the environment variables `MXNET_ENABLE_CYTHON` and `MXNET_ENFORCE_CYTHON` is added. 1. Documentation for the optional cython build is added to the install guide. 1. Python3 CentOS 7 CPU and Python3 CentOS 7 GPU environments in the CI now use the cython modules. `make cython` generates two `.so` files in `mxnet/_cy3` (or `_cy2` with python 2). The exact names of the files depend on the environment. They don't need a special care for installation. It is enough just to be there.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
