jinhuang415 commented on issue #11090: Define build target for mkldnn lib build to fix 'make clean USE_MKMLDNN=1' issue URL: https://github.com/apache/incubator-mxnet/pull/11090#issuecomment-398975623 @szha We removed MKLDNN_ROOT (make variable) support in new diff since we found it is not necessary to use another directory to hold the built library/header file(we can always use 3rdparty/mkldnn/install), if there is need to use pre-installed mkldnn library we can add support in another PR. Regarding the name, I still use MKLDNNROOT to keep consistent with mkldnn github repo README (https://github.com/intel/mkl-dnn#linking-your-application) and changed some variable names in mkldnn.mk, hope it can make less confusion.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
