lanking520 commented on a change in pull request #10451: [MXNET-432] Add Foreach
URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r197030113
##########
File path:
scala-package/macros/src/main/scala/org/apache/mxnet/utils/CToScalaUtils.scala
##########
@@ -33,7 +33,7 @@ private[mxnet] object CToScalaUtils {
case "double" | "doubleorNone" => "Double"
case "string" => "String"
case "boolean" | "booleanorNone" => "Boolean"
- case "tupleof<float>" | "tupleof<double>" | "ptr" | "" => "Any"
+ case "tupleof<float>" | "tupleof<double>" | "tupleof<long>" | "ptr" | ""
=> "Any"
Review comment:
Should be `tupleof<>` in here from the error message
```
java.lang.IllegalArgumentException: Invalid type for args: tupleof<>, tuple
of <>, required
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
