reminisce commented on a change in pull request #11325: Added TensorRT runtime
integration
URL: https://github.com/apache/incubator-mxnet/pull/11325#discussion_r197672536
##########
File path: include/mxnet/executor.h
##########
@@ -152,19 +152,19 @@ class Executor {
static Executor* SimpleBind(nnvm::Symbol symbol,
const Context& default_ctx,
const std::map<std::string, Context>& group2ctx,
- const std::vector<Context>& in_arg_ctxes,
- const std::vector<Context>& arg_grad_ctxes,
- const std::vector<Context>& aux_state_ctxes,
- const std::unordered_map<std::string, TShape>&
arg_shape_map,
- const std::unordered_map<std::string, int>&
arg_dtype_map,
- const std::unordered_map<std::string, int>&
arg_stype_map,
- const std::vector<OpReqType>& grad_req_types,
- const std::unordered_set<std::string>&
param_names,
+ std::vector<Context>* in_arg_ctxes,
Review comment:
Question: what is the purpose of modifying these arguments by passing
pointers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
