KellenSunderland commented on a change in pull request #11325: Added TensorRT 
runtime integration
URL: https://github.com/apache/incubator-mxnet/pull/11325#discussion_r198120177
 
 

 ##########
 File path: include/mxnet/executor.h
 ##########
 @@ -152,19 +152,19 @@ class Executor {
   static Executor* SimpleBind(nnvm::Symbol symbol,
 
 Review comment:
   @reminisce: I'm not sure that I'd consider this a breaking API change.  My 
understanding from what was discussed  the dev list was that we would follow 
the hour-glass model for the c_api, and make the c_api the only native 
interface that we semantically version.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to