reminisce commented on a change in pull request #11406: [MXNET-599] Partial shape infer for Slice URL: https://github.com/apache/incubator-mxnet/pull/11406#discussion_r198699168
########## File path: src/operator/tensor/matrix_op-inl.h ########## @@ -690,9 +701,10 @@ inline bool SliceOpShape(const nnvm::NodeAttrs& attrs, CHECK_EQ(in_attrs->size(), 1U); CHECK_EQ(out_attrs->size(), 1U); const TShape& dshape = (*in_attrs)[0]; - if (dshape.ndim() == 0 || dshape.Size() == 0) return false; Review comment: Since we are removing one of the checks, please add ```cpp return !shape_is_none(dshape) && !shape_is_none(oshape) ``` at the end of this function. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
