reminisce commented on a change in pull request #10889: [MXNET-382] Shape and Size Operator URL: https://github.com/apache/incubator-mxnet/pull/10889#discussion_r198700221
########## File path: src/operator/tensor/elemwise_unary_op.h ########## @@ -388,6 +388,20 @@ void CastCompute(const nnvm::NodeAttrs& attrs, }); } +template<typename xpu> +void ShapeCompute(const nnvm::NodeAttrs& attrs, Review comment: You don't need to make templates for shape and size functions based on the type of device. CPU and GPU FCompute functions are defined respectively in .cc and .cu and don't share anything. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
