anirudhacharya commented on a change in pull request #11229: [MXNET-379] L1
Normalization
URL: https://github.com/apache/incubator-mxnet/pull/11229#discussion_r199026365
##########
File path: src/operator/tensor/broadcast_reduce_op.h
##########
@@ -1021,8 +1023,38 @@ void L2NormGradCompute(const nnvm::NodeAttrs& attrs,
} else {
small = ReduceAxesShapeImpl(outputs[0].shape_, param.axis, true, false);
}
- ReduceAxesBackwardUseInOutImpl<xpu, mshadow_op::div, false>(ctx, small,
inputs,
+ if (param.ord == 1) {
+ using namespace mshadow;
+ using namespace mshadow::expr;
+ TShape src_shape, dst_shape;
+ BroadcastReduceShapeCompact(outputs[0].shape_, small, &src_shape,
&dst_shape);
+ Stream<xpu> *s = ctx.get_stream<xpu>();
+ MSHADOW_TYPE_SWITCH(outputs[0].type_flag_, DType, {
+ if (dst_shape.ndim() == 2) {
+ Tensor<xpu, 2, DType> ograd =
+ inputs[0].get_with_shape<xpu, 2, DType>(dst_shape.get<2>(), s);
+ Tensor<xpu, 2, DType> igrad =
+ outputs[0].get_with_shape<xpu, 2, DType>(src_shape.get<2>(), s);
+ Tensor<xpu, 2, DType> data =
+ inputs[1].get_with_shape<xpu, 2, DType>(src_shape.get<2>(), s);
+ ASSIGN_DISPATCH(igrad, req[0],
+ broadcast_to(ograd, src_shape)*F<mshadow_op::sign>(data));
+ } else {
+ const int ndim = MXNET_SPECIAL_MAX_NDIM;
+ Tensor<xpu, ndim, DType> igrad =
+ outputs[0].get_with_shape<xpu, ndim, DType>(src_shape.get<ndim>(),
s);
+ Tensor<xpu, ndim, DType> ograd =
+ inputs[0].get_with_shape<xpu, ndim, DType>(dst_shape.get<ndim>(), s);
+ Tensor<xpu, ndim, DType> data =
+ inputs[1].get_with_shape<xpu, ndim, DType>(src_shape.get<ndim>(), s);
+ ASSIGN_DISPATCH(igrad, req[0],
+ broadcast_to(ograd, src_shape)*F<mshadow_op::sign>(data));
+ }
+ });
+ } else if (param.ord == 2) {
+ ReduceAxesBackwardUseInOutImpl<xpu, mshadow_op::div, false>(ctx, small,
inputs,
req, outputs);
Review comment:
it is aligned properly, it even passed the cpplint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
