nswamy commented on a change in pull request #11239: [MXNET-319] Javadoc fix
URL: https://github.com/apache/incubator-mxnet/pull/11239#discussion_r199126757
##########
File path:
scala-package/macros/src/main/scala/org/apache/mxnet/APIDocGenerator.scala
##########
@@ -55,16 +69,44 @@ private[mxnet] object APIDocGenerator{
val imports = "import org.apache.mxnet.annotation.Experimental"
val absClassDef = s"abstract class $packageName"
val finalStr =
s"$apacheLicence\n$scalaStyle\n$packageDef\n$imports\n$absClassDef
{\n${absFuncs.mkString("\n")}\n}"
+ val pw = new PrintWriter(new File(FILE_PATH + s"$packageName.scala"))
+ pw.write(finalStr)
+ pw.close()
+ MD5Generator(finalStr)
+ }
+
+ def nonTypeSafeClassGen(FILE_PATH : String, isSymbol : Boolean) : String = {
+ // scalastyle:off
+ val absClassFunctions = getSymbolNDArrayMethods(isSymbol)
+ val absFuncs =
absClassFunctions.filterNot(_.name.startsWith("_")).map(absClassFunction => {
Review comment:
Can you move this filter to the getSymbolNDArrayMethods, so we have one
place to change in when start adding support for `_sparse_` etc.,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
