mkolod commented on issue #11380: Add ability to query cuDNN BatchNorm min. 
epsilon. Allow ONNX importer to use cuDNN BN if chosen eps >= cuDNN min. eps.
URL: https://github.com/apache/incubator-mxnet/pull/11380#issuecomment-402252067
 
 
   @szha Yes. @piiswrong pointed out that the C API was overkill (see 
[here](https://github.com/apache/incubator-mxnet/pull/11380#issuecomment-401100387)).
 You suggested that I follow @piiswrong's recommendation in this matter (see 
[here](https://github.com/apache/incubator-mxnet/pull/11380#pullrequestreview-133033750)).
 @piiswrong's last suggestion to my request for feedback 
([here](https://github.com/apache/incubator-mxnet/pull/11380#issuecomment-401122235))
 has been to hard-code the value for `CUDNN_BN_MIN_EPSILON` to be 1e-5, I'm 
assuming because that value is expected to be stable (see @piiswrong's comment 
[here](https://github.com/apache/incubator-mxnet/pull/11380#issuecomment-401906530)).
 So yes, the C API has been removed and the constant inserted in the ONNX 
importer, per @piiswrong's suggestion 
[here](https://github.com/apache/incubator-mxnet/pull/11380#issuecomment-401906530).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to