threeleafzerg commented on issue #10696: [MXNET-366]Extend MXNet Distributed Training by AllReduce URL: https://github.com/apache/incubator-mxnet/pull/10696#issuecomment-402334430 @xcgoner Deep insight and good review comment! 1. I think it's better to override explicitly in direct interface (push and pull) to warn the end user not to use these interfaces in this allreduce kvstore. 2. You are right. Finished code modification according to your comments. 3. Good catch. I will try override $(CXX) when USE_ALLREDUCE_DIST_KVSTORE is on. Looks like normally mpicxx is just a wrapper for your local g++.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
