haojin2 commented on a change in pull request #11559: [MXNET-392] Support for a bunch of unary functions for csr matrices URL: https://github.com/apache/incubator-mxnet/pull/11559#discussion_r200210858
########## File path: src/operator/tensor/elemwise_unary_op_basic.cc ########## @@ -70,7 +70,7 @@ static bool IdentityAttrLikeRhsStorageType(const nnvm::NodeAttrs& attrs, } // relu -MXNET_OPERATOR_REGISTER_UNARY(relu) +MXNET_OPERATOR_REGISTER_UNARY_WITH_RSP_CSR(relu, cpu, mshadow_op::relu) Review comment: Actually none of MXNET_OPERATOR_REGISTER_UNARY_WITH_RSP_CSR/MXNET_OPERATOR_REGISTER_UNARY_WITH_RSP/MXNET_OPERATOR_REGISTER_UNARY_WITH_SPARSE_DR has MXNET_ADD_SPARSE_OP_ALIAS in them, do you want to add that to all of them? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
