junrushao1994 opened a new pull request #11566: [WIP] Add while_loop URL: https://github.com/apache/incubator-mxnet/pull/11566 ## Description ## (Brief description on what this PR is about) This PR is part of the proposal of adding a set of control flow operators to MXNet. [Link](https://cwiki.apache.org/confluence/display/MXNET/Optimize+dynamic+neural+network+models+with+control+flow+operators) to proposal. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes) - [x] Changes are complete (i.e. I finished coding on this PR) - [x] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [x] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - Add while_loop operator in `src/operator/control_flow.cc` ## Comments ## - If this change is a backward incompatible change, why must this change be made. - Interesting edge cases to note here ## TODO ## - [ ] Do we need a JIRA_ID? @zheng-da - [ ] Add more testcases - [ ] Benchmark while_loop - [ ] Split control_flow.cc into foreach and while_loop - [ ] Merge the standalone unittest file test_while_loop.py into test_operator.py - [ ] Re-examine all `TODO(Junru)` in changes
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
