roywei commented on issue #11544: [MXNET-620][WIP][Do not merge]Fix flaky test 
batchnorm training
URL: https://github.com/apache/incubator-mxnet/pull/11544#issuecomment-402818788
 
 
   - Updated conclusion. 
   - Removed 'row_sparse' from stypes for the following reasons:
   1. It's failing at testing varying [channel axis 
](https://github.com/apache/incubator-mxnet/blob/e870890ab93ae25d51da01a445c965e4db71069b/tests/python/unittest/test_operator.py#L1524),
 this test already has rtol=0.2 and atol=0.01, we cant further increase rtol 
and atol.
   2. row_sparse is never used and always fallback in this test, the logic is 
also tested tested at[ 
mkl/test_mkldnn.py](https://github.com/apache/incubator-mxnet/blob/e870890ab93ae25d51da01a445c965e4db71069b/tests/python/mkl/test_mkldnn.py#L218)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to