lanking520 commented on a change in pull request #11596: [MXNET-531]
Integration Test for Scala
URL: https://github.com/apache/incubator-mxnet/pull/11596#discussion_r201138066
##########
File path: Makefile
##########
@@ -593,7 +593,13 @@ scalapkg:
-Dcurrent_libdir="$(ROOTDIR)/lib" \
-Dlddeps="$(LIB_DEP) $(ROOTDIR)/lib/libmxnet.a")
-scalatest:
+scalaunittest:
+ (cd $(ROOTDIR)/scala-package; \
+ mvn integration-test
-P$(SCALA_PKG_PROFILE),$(SCALA_VERSION_PROFILE) -Dcxx="$(CXX)" \
+ -Dcflags="$(CFLAGS)" -Dldflags="$(LDFLAGS)" \
+ -Dlddeps="$(LIB_DEP) $(ROOTDIR)/lib/libmxnet.a"
$(SCALA_TEST_ARGS))
+
+scalaintegrationtest:
Review comment:
Currently, all unit test are run on `integration-test` stage in Maven and
all integration test runs in `verify` stage.
Yes, it runs unit test as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
